-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add row context (right click) additionally to actions in tables #8013
Add row context (right click) additionally to actions in tables #8013
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8013 +/- ##
==========================================
+ Coverage 84.38% 84.41% +0.02%
==========================================
Files 1178 1178
Lines 53733 53744 +11
Branches 2022 2027 +5
==========================================
+ Hits 45345 45368 +23
+ Misses 7875 7849 -26
- Partials 513 527 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think we need to have a larger conversation about how we interact with tables - and make the "user expectation" consistent. There are:
Is there a way we can visually indicate what happens when you left-click or right-click on a row, do you think? |
I am not aware that other apps provide this, have not seen this pattern somewhere else consciously. Maybe linking somewhere else should just be a highlighted link somewhere at the beginning of the table to make it clear. |
@SchrodingersGat how should we proceed here? |
@matmair I am happy with this in principle. Looking at the current state, there are some visual styling issues that need to be addressed: Here is a regular row-context menu (via the drop-down in the "actions" column): And the same menu accessed via right-click context menu: So, the colors need fixing, and some padding around the menu item |
I will look into reusing the renderer from the actions dropdown |
@SchrodingersGat I have addressed the styling; ready for review & merge |
Fantastic, looks great now. This is a really nice addition. |
This draft PR adds right-click context menus to tables. The content can be determined by a custom callback or computed from the row actions.
I am interested in feedback - you should be able to play with it using the preview deployment.
Closes invenhost#128